Merge branch 'master' into configure-load-message-limit

GetStream · Aug 17, 2022 · 4e0cd33 · 4e0cd33
2 parents c12b0ff + a516cc1
commit 4e0cd33
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/client.ts b/src/client.ts
@@ -579,8 +579,12 @@ export class StreamChat<StreamChatGenerics extends ExtendableGenerics = DefaultG
     }
    */
   async updateAppSettings(options: AppSettings) {
-    if (options.apn_config?.p12_cert) {
-      options.apn_config.p12_cert = Buffer.from(options.apn_config.p12_cert).toString('base64');
+    const apn_config = options.apn_config;
+    if (apn_config?.p12_cert) {
+      options = {
+        ...options,
+        apn_config: { ...apn_config, p12_cert: Buffer.from(apn_config.p12_cert).toString('base64') },
+      };
     }
     return await this.patch<APIResponse>(this.baseURL + '/app', options);
   }

diff --git a/test/unit/client.js b/test/unit/client.js
@@ -68,6 +68,15 @@ describe('StreamChat getInstance', () => {
 
 		expect(client.baseURL).to.equal(baseURL);
 	});
+
+	it('app settings do not mutate', async () => {
+		const client = new StreamChat('key', 'secret');
+		const cert = Buffer.from('test');
+		const options = { apn_config: { p12_cert: cert } };
+		await expect(client.updateAppSettings(options)).to.be.rejectedWith(/.*/);
+
+		expect(options.apn_config.p12_cert).to.be.eql(cert);
+	});
 });
 
 describe('Client userMuteStatus', function () {