Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support limit for load message into state #1031

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

petyosi
Copy link
Contributor

@petyosi petyosi commented Aug 17, 2022

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

This change allows the SDKs to increase the size of the messages loaded when jumping, thus avoiding multiple requests to the db.

Changelog

loadMessageIntoState accepts an optional limit parameter, (default value is 25)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

Size Change: +161 B (0%)

Total Size: 308 kB

Filename Size Change
dist/browser.es.js 67.5 kB +40 B (0%)
dist/browser.full-bundle.min.js 36.9 kB +12 B (0%)
dist/browser.js 68.4 kB +34 B (0%)
dist/index.es.js 67.5 kB +42 B (0%)
dist/index.js 68.3 kB +33 B (0%)

compressed-size-action

src/channel_state.ts Outdated Show resolved Hide resolved
AnatolyRugalev
AnatolyRugalev previously approved these changes Aug 17, 2022
szuperaz
szuperaz previously approved these changes Aug 18, 2022
Copy link
Contributor

@szuperaz szuperaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSdoc for the limit parameter is missing, but the changes look good to me

MartinCupela
MartinCupela previously approved these changes Aug 18, 2022
@petyosi petyosi dismissed stale reviews from MartinCupela and szuperaz via 08a0dd6 August 18, 2022 14:16
@petyosi petyosi force-pushed the configure-load-message-limit branch from 4e0cd33 to 08a0dd6 Compare August 18, 2022 14:16
@petyosi petyosi enabled auto-merge (squash) August 18, 2022 14:24
@petyosi petyosi disabled auto-merge August 18, 2022 14:30
@petyosi petyosi merged commit 2968785 into master Aug 18, 2022
@petyosi petyosi deleted the configure-load-message-limit branch August 18, 2022 14:30
@github-actions github-actions bot mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants