Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding message to an empty message list #1356

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: adding message to an empty message list #1356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,10 @@ export function addToMessageList<T extends FormatMessageResponse>(
}

// for empty list just concat and return unless it's an update or deletion
if (!newMessages.length && addMessageToList) {
if (newMessages.length === 0 && addMessageToList) {
return newMessages.concat(newMessage);
} else if (newMessages.length === 0) {
return newMessages;
}

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
Expand All @@ -396,6 +398,8 @@ export function addToMessageList<T extends FormatMessageResponse>(
// if message is newer than last item in the list concat and return unless it's an update or deletion
if (messageIsNewest && addMessageToList) {
return newMessages.concat(newMessage);
} else if (newMessages.length === 0) {
return newMessages;
}

// find the closest index to push the new message
Expand Down
Loading