Fix member ordering for creating member based channels #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, it is a unit test than an integration test, we could remove it too since covered. |
mahboubii
reviewed
Jan 21, 2021
test/integration/channels.js
Outdated
| @@ -123,7 +123,7 @@ describe('Channels - Constructor', function () { | |||
|
|
|||
| it('short version with options', function (done) { | |||
| const channel = client.channel('messaging', { members: ['tommaso', 'thierry'] }); | |||
| expect(channel.data).to.eql({ members: ['tommaso', 'thierry'] }); | |||
| expect(channel.data).to.eql({ members: ['thierry', 'tommaso'] }); | |||
There was a problem hiding this comment.
this test seems to be a better fit for unit tests. is this due to recent changes? the member order should remain the same
There was a problem hiding this comment.
yes, it comes from member based channel creation fix.
I agree with unit.
There was a problem hiding this comment.
oh I see, the sort is applied in place, I think it's better to revert that change
There was a problem hiding this comment.
I will make a fix to sort the copy and move this test to unit tests.
There was a problem hiding this comment.
ahh, updated this one
vishalnarkhede
approved these changes
Jan 21, 2021
ferhatelmas
force-pushed
the
fix-member-order
branch
from
e072a9d
to
23c1d8a
Compare
|
Size Change: -67 B (0%) Total Size: 214 kB
|
ferhatelmas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it's sorted now.