Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try arping as last resort #52

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Try arping as last resort #52

merged 1 commit into from
Dec 5, 2019

Conversation

scop
Copy link
Contributor

@scop scop commented Dec 4, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Code changes:

  • Did you format your code with Black?
    • black getmac tests
  • Are the linting checks passing?
    • tox -e check -- no, but they weren't passing before this change either:
check run-test: commands[3] | flake8 getmac tests setup.py
getmac/getmac.py:1:1: T499 Success: no issues found in 1 source file
# -*- coding: utf-8 -*-
^
ERROR: InvocationError for command [...]/getmac/.tox/check/bin/flake8 getmac tests setup.py (exited with code 1)
  • Do all tests pass locally?
    • tox
  • Have you updated the CHANGELOG with a summary of your change?
  • Did you add your name to the contributors list in the README?

Summary of changes:

When other things have yielded no results, try arping. Depending on system, it may require an interface to be specified and fail without one, but would improve things where it doesn't.

@GhostofGoes
Copy link
Owner

This looks great, thank you! Hopefully this helps fix the problem in the mentioned issue (or at least avoid related issues in the future)!

@GhostofGoes GhostofGoes merged commit 994c415 into GhostofGoes:master Dec 5, 2019
@GhostofGoes
Copy link
Owner

Will try to get this released on PyPI as 0.8.2 by this Saturday

@scop scop deleted the arping branch December 5, 2019 06:19
@scop
Copy link
Contributor Author

scop commented Dec 5, 2019

Thanks! Turns out it doesn't immediately seem to fix the problem, but I believe it's a good addition to have in getmac anyway.

Alas, I've learned that the https://github.com/ThomasHabets/arping arping implementation doesn't support the -f option, and its output differs from the iputils/busybox arping somewhat as well. So for now this implementation doesn't work with the ThomasHabets one -- I'll see if I can get the -f option supported there too, as well as submit a followup PR here to recognize its output. (The -f could in theory be dropped, but it makes the call a bit faster, so I think it's good to keep it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants