Crowd Assessment: Url for url generation #1672
Conversation
* Use Url class for url generations. * Fix require_once path with __DIR__.
| $form = Form::create('crowdAssessment', $gibbon->session->get('absoluteURL').'/modules/'.$session->get('module')."/crowdAssess_view_discuss_postProcess.php?gibbonPlannerEntryID=$gibbonPlannerEntryID&gibbonPlannerEntryHomeworkID=$gibbonPlannerEntryHomeworkID&address=".$_GET['q']."&gibbonPersonID=$gibbonPersonID&replyTo=$replyTo"); | ||
| $form = Form::create( | ||
| 'crowdAssessment', | ||
| Url::fromModuleRoute('Crowd Assessment', 'crowdAssess_view_discuss_postProcess') |
There was a problem hiding this comment.
Hi Koala, I've taken a look at this but I think there may be a type of Url that the Url class cannot properly generate. For forms and process pages, the url needs to go directly to the script itself rather than prepending the index.php module route. In this case, testing your changes in a local system, this form will create an error when submitted because it is trying to go to index.php as a front-end page, not the script itself. I'm curious to hear the best way to handle this, do we add a new method to Url, or add a qualifier to the methods used to build the Url after fromModuleRoute is called. What do you think?
There was a problem hiding this comment.
I wanted to try (in fact I tried to write tests for Crowd Assessment in the past few weeks) but I don't quite know how to use and test it :-(
Can you give me some directions?
There was a problem hiding this comment.
Fair enough, this one is a bit tricky to setup for testing! 😅 Ff you go into the Planner, pick a demo Class that you "teach" and then add a new lesson plan. Make sure the lesson plan date is in the past week or so (not the future), then enable the Homework option with a deadline in the future, then enable Online Submission, and finally enable the Crowd Assessment option. This should create a crowd-assessable lesson. Once created, click to View your lesson plan and you can manually add a submission for a student using the Edit option. Once a student has a submission it should show up in the Crowd Assessment module list. Hope this helps!
There was a problem hiding this comment.
@SKuipers In the demo data, which class do "I" actually "teach"? Or how do I make my account "teach" a class?
There was a problem hiding this comment.
In the demo data you'll have the FL07.1, FL07.2, FL07.3 and FL07.4 classes, they often show up at the top of the classes list under My Classes. To add yourself to a class, you can go into Timetable Admin > Course Enrolment by Person (or by Class). Hope this helps!
Description
Motivation and Context
How Has This Been Tested?