-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 整地報酬ガチャ券受取ボタンに右クリックして1スタックだけ引き出せるようにする機能を追加 #2371
Merged
rito528
merged 18 commits into
GiganticMinecraft:1_18
from
kuroma6666:update-gacha-ticket-recv-button
Sep 3, 2024
Merged
feat: 整地報酬ガチャ券受取ボタンに右クリックして1スタックだけ引き出せるようにする機能を追加 #2371
rito528
merged 18 commits into
GiganticMinecraft:1_18
from
kuroma6666:update-gacha-ticket-recv-button
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sk9
changed the title
update: 整地報酬ガチャ券受取ボタンに右クリックして1スタックだけ引き出せるようにする機能を追加
feat: 整地報酬ガチャ券受取ボタンに右クリックして1スタックだけ引き出せるようにする機能を追加
Sep 1, 2024
タイトルを修正しました |
rito528
requested changes
Sep 1, 2024
src/main/scala/com/github/unchama/seichiassist/subsystems/gachapoint/System.scala
Outdated
Show resolved
Hide resolved
...scala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/BatchUsageSemaphore.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
rito528
requested changes
Sep 1, 2024
src/main/scala/com/github/unchama/seichiassist/menus/stickmenu/FirstPage.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/unchama/seichiassist/subsystems/gachapoint/System.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...scala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/BatchUsageSemaphore.scala
Outdated
Show resolved
Hide resolved
rito528
requested changes
Sep 1, 2024
src/main/scala/com/github/unchama/seichiassist/subsystems/gachapoint/GachaPointApi.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/unchama/seichiassist/subsystems/gachapoint/GachaPointApi.scala
Outdated
Show resolved
Hide resolved
rito528
requested changes
Sep 3, 2024
src/main/scala/com/github/unchama/seichiassist/subsystems/gachapoint/System.scala
Outdated
Show resolved
Hide resolved
...scala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/BatchUsageSemaphore.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...ala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/gachapoint/GachaPoint.scala
Outdated
Show resolved
Hide resolved
...scala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/BatchUsageSemaphore.scala
Outdated
Show resolved
Hide resolved
...scala/com/github/unchama/seichiassist/subsystems/gachapoint/domain/BatchUsageSemaphore.scala
Show resolved
Hide resolved
largeBatchSizeの個数と等価とする
rito528
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM.
src/main/scala/com/github/unchama/seichiassist/menus/stickmenu/FirstPage.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/unchama/seichiassist/menus/stickmenu/FirstPage.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/unchama/seichiassist/menus/stickmenu/FirstPage.scala
Outdated
Show resolved
Hide resolved
rito528
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ありがとうございます👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2152
このPRの変更点と理由:
※loreの表示イメージ:
追記: