Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elegant logging using the logging module #59

Closed
GijsTimmers opened this issue Jan 3, 2015 · 5 comments
Closed

Elegant logging using the logging module #59

GijsTimmers opened this issue Jan 3, 2015 · 5 comments
Assignees
@jovanbulck
Labels
enhancement @medium
Milestone
3.0.0: 'Cape Cod'

Comments

@GijsTimmers
Copy link
Owner

Debug stuff like ik wil bellen blazen should be elegantly logged using the python logging module.

We will work on this when kotnetcli 2.0.0 is released.
@GijsTimmers GijsTimmers added this to the 3.0.0 milestone Jan 3, 2015
@jovanbulck jovanbulck mentioned this issue Feb 13, 2015
Closed
jovanbulck added a commit that referenced this issue Feb 13, 2015
@jovanbulck
implemented basic logging in issue #59
1994507
@jovanbulck
Copy link
Collaborator

implemented basic idea, linked above; added --debug option (toggled on by default in kotnetcli_test.py)

screenshot from 2015-02-13 16 57 49
screenshot from 2015-02-13 16 59 50

jovanbulck added a commit that referenced this issue Feb 13, 2015
@jovanbulck
issue #59 custom debug verbosity level [ critical > error > warning (…
a45da02 
…default) > info > debug ]
@GijsTimmers
Copy link
Owner Author

Exactly. Nice job!

@jovanbulck
Copy link
Collaborator

note: whereas logging of setup-errors (eg import failed or so) is fine, we should better not use the logging system to provide users with login-procedure (i.e. worker) errors (as I did in the above commits)

Instead, we should think about changing the communicator API with error feedback methods

@GijsTimmers
Copy link
Owner Author

Yes, just use the communicator for expected errors, and use the logging module for more detail on what's happening.

jovanbulck added a commit that referenced this issue Oct 10, 2015
@jovanbulck
Added command line option to choose institution; Fixes issue #85
e159d8c 
Browser now handles errorcode 211 (unknown institution) and I
also updated the testsuite and added a test clause for rc 211

We still have to look into:
    - what are all the valid institutions??
    - error messages should be communicated to the user via
        the communicator system (as discussed in issue #59)

Usage examples:

kotnetcli # default = kuleuven
kotnetcli --institution=kuleuven-campusnet
kotnetcli_test -r
kotnetcli_test -r --timeout=0.5 --institution=kuleuven-campusnet
@jovanbulck jovanbulck mentioned this issue Oct 10, 2015
Closed
@GijsTimmers GijsTimmers mentioned this issue Apr 19, 2016
Open
@jovanbulck jovanbulck mentioned this issue Apr 20, 2016
Closed
@jovanbulck
Copy link
Collaborator

Yes, just use the communicator for expected errors, and use the logging module for more detail on what's happening.

Done #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jovanbulck jovanbulck

Labels
enhancement @medium
Projects
None yet
Milestone
3.0.0: 'Cape Cod'
Development

No branches or pull requests
2 participants
@GijsTimmers @jovanbulck