Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geom.violin with color #1081

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Geom.violin with color #1081

merged 1 commit into from
Jan 5, 2018

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Jan 2, 2018

Enables mapping violin color to a suitable variable (#1074).
An example:

using DataFrames
group = ["S","A","T"]
D = vcat([DataFrame( y=(j-1)+randn(20), x=g*"$j", group=g)  for j in 1:2, g in group]...)
plot(D, x=:x, y=:y, Geom.violin, color=:group)

issue1074

@bjarthur
Copy link
Member

bjarthur commented Jan 5, 2018

looks great. do you have time to update the documentation to mention that color is an aesthetic?

@codecov-io
Copy link

Codecov Report

Merging #1081 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files          32       32           
  Lines        3939     3939           
=======================================
  Hits         3402     3402           
  Misses        537      537
Impacted Files Coverage Δ
src/statistics.jl 93.21% <100%> (+0.53%) ⬆️
src/geom/violin.jl 100% <100%> (ø) ⬆️
src/geom/polygon.jl 55.55% <0%> (-8.89%) ⬇️
src/theme.jl 64.15% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38a093...57df6e0. Read the comment docs.

@Mattriks
Copy link
Member Author

Mattriks commented Jan 5, 2018

Ok, done.

@bjarthur bjarthur merged commit a61f52b into GiovineItalia:master Jan 5, 2018
@bjarthur
Copy link
Member

bjarthur commented Jan 5, 2018

thanks!

@Mattriks
Copy link
Member Author

Mattriks commented Jan 5, 2018

Great! Issues #1074 and #1018 can be closed

@bjarthur
Copy link
Member

bjarthur commented Jan 5, 2018

closed them. next time, start your original post with "closes " and then the issue numbers and it will auto-close them when merged. thanks again!

@tlnagy tlnagy mentioned this pull request May 25, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants