-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce in memory git metadata 2 #1244
Closed
JakeGinnivan
wants to merge
13
commits into
GitTools:master
from
JakeGinnivan:feature/IntroduceInMemoryGitMetadata2
Closed
introduce in memory git metadata 2 #1244
JakeGinnivan
wants to merge
13
commits into
GitTools:master
from
JakeGinnivan:feature/IntroduceInMemoryGitMetadata2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully will end up with us getting rid of normalisation and making GitVersion much faster
This reduces scanning the branch commits by one pass
…ersionStrategy to be fixed after changes to TaggedCommitVersionStrategy
Commit counting needs to be revisited, but overall promising
…mit count comes from the commit the config was updated These tests can safely change
It is checking the merge doesn't reset the commit count, the new commit counting logic slightly changes the source commit which means it is the merge base rather than the first commit on the merged branch, looks ok to update this
Closed
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going further than #1243.