Add support and tests for AssemblyInformationalVersion configurability #660
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| namespace GitVersion | ||
| { | ||
| public class SemanticVersionFormatValues | ||
|
There was a problem hiding this comment. Why can't we use the There was a problem hiding this comment. We need this class in order to generate the VersionVariables class since the types we're using int he formatting need to come from a constructed object. And if we exposed the VersionVariables object as what's valid for formatting, then someone could do {InformationalVersion} and get themselves into an infinite loop. So this gives us type safety of what's allowed to be formatted as well as getting the formatting done to construct the VersionVariables type. I agree it's redundant on most fields (since VersionVariables now just becomes a passthrough/holder for most of the values calculated in the SemanticVersionFormatValues class. Open to suggestions to minimize here if you have them. |
||
| { | ||
| readonly SemanticVersion _semver; | ||
| readonly EffectiveConfiguration _config; | ||
|
|
||
| public SemanticVersionFormatValues(SemanticVersion semver, EffectiveConfiguration config) | ||
| { | ||
| _semver = semver; | ||
| _config = config; | ||
| } | ||
|
|
||
| public string Major | ||
| { | ||
| get { return _semver.Major.ToString(); } | ||
| } | ||
|
|
||
| public string Minor | ||
| { | ||
| get { return _semver.Minor.ToString(); } | ||
| } | ||
|
|
||
| public string Patch | ||
| { | ||
| get { return _semver.Patch.ToString(); } | ||
| } | ||
|
|
||
| public string PreReleaseTag | ||
| { | ||
| get { return _semver.PreReleaseTag; } | ||
| } | ||
|
|
||
| public string PreReleaseTagWithDash | ||
| { | ||
| get { return _semver.PreReleaseTag.HasTag() ? "-" + _semver.PreReleaseTag : null; } | ||
| } | ||
|
|
||
| public string BuildMetaData | ||
| { | ||
| get { return _semver.BuildMetaData; } | ||
| } | ||
|
|
||
| public string BuildMetaDataPadded | ||
| { | ||
| get { return _semver.BuildMetaData.ToString("p" + _config.BuildMetaDataPadding); } | ||
| } | ||
|
|
||
| public string FullBuildMetaData | ||
| { | ||
| get { return _semver.BuildMetaData.ToString("f"); } | ||
| } | ||
|
|
||
| public string MajorMinorPatch | ||
| { | ||
| get { return string.Format("{0}.{1}.{2}", _semver.Major, _semver.Minor, _semver.Patch); } | ||
| } | ||
|
|
||
| public string SemVer | ||
| { | ||
| get { return _semver.ToString(); } | ||
| } | ||
|
|
||
| public string LegacySemVer | ||
| { | ||
| get { return _semver.ToString("l"); } | ||
| } | ||
|
|
||
| public string LegacySemVerPadded | ||
| { | ||
| get { return _semver.ToString("lp" + _config.LegacySemVerPadding); } | ||
| } | ||
|
|
||
| public string AssemblySemVer | ||
| { | ||
| get { return _semver.GetAssemblyVersion(_config.AssemblyVersioningScheme); } | ||
| } | ||
|
|
||
| public string FullSemVer | ||
| { | ||
| get { return _semver.ToString("f"); } | ||
| } | ||
|
|
||
| public string BranchName | ||
| { | ||
| get { return _semver.BuildMetaData.Branch; } | ||
| } | ||
|
|
||
| public string Sha | ||
| { | ||
| get { return _semver.BuildMetaData.Sha; } | ||
| } | ||
|
|
||
| public string CommitDate | ||
| { | ||
| get { return _semver.BuildMetaData.CommitDate.UtcDateTime.ToString("yyyy-MM-dd"); } | ||
| } | ||
|
|
||
| // TODO When NuGet 3 is released: public string NuGetVersionV3 { get { return ??; } } | ||
|
|
||
| public string NuGetVersionV2 | ||
| { | ||
| get { return LegacySemVerPadded.ToLower(); } | ||
| } | ||
|
|
||
| public string NuGetVersion | ||
| { | ||
| get { return NuGetVersionV2; } | ||
| } | ||
|
|
||
| public string DefaultInformationalVersion | ||
| { | ||
| get { return _semver.ToString("i"); } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also like to see a test which uses multiple format values. i.e
'{Major}.{Minor}.{Patch}'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.