Fix invalid dependency on updateAssemblyInfoFilename input #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream master
- Changed 'GitVersionTool.getArguments' to check the 'updateAssemblyInfoFilename' input string only if it's not empty.
chris-codeflow
changed the title
|
Hello @arturcic. Bug fix PR ready for review. |
|
Please can you 'squash commit' this PR (when complete) to avoid all the 'merge' commits. I will sort my fork out to avoid this in the future. |
asbjornu
approved these changes
Feb 5, 2021
This was referenced Feb 5, 2021
arturcic
approved these changes
Feb 5, 2021
|
@chris-codeflow thank you so much for your contributions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed invalid dependency on
updateAssemblyInfoFilenameinput.Changed
GitVersionTool.getArgumentsto check and use theupdateAssemblyInfoFilenameinput string only if it's not empty. This allows the execute task users to use theupdateAssemblyInfoinput in isolation, resulting in the GitVersion tool's default behaviour of recursively searching for and updating all 'AssemblyInfo.cs' files in the Git repository.Fixes issue #125.