Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If possible, set assignee to the original PR's author #13

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

yardenshoham
Copy link
Collaborator

The calls are separated to allow the assignee call to fail and still let the milestone call to pass

The calls are separated to allow the assignee call to fail and still let the milestone call to pass
@jolheiser
Copy link
Collaborator

We hadn't done this in the past, is there a reason to do so now?

@yardenshoham
Copy link
Collaborator Author

If a backport PR needs some work (for example go-gitea/gitea@28f55bd), someone should own it.

@jolheiser
Copy link
Collaborator

Hmm, but even then an assignee can't push to the branch to fix any issues, right?

@yardenshoham
Copy link
Collaborator Author

That's right but that's the best we can do... It's better than nothing

@yardenshoham
Copy link
Collaborator Author

BTW this will only assign go-gitea org members

@jolheiser
Copy link
Collaborator

BTW this will only assign go-gitea org members

Ah, I didn't know this part. That makes it a bit better, but still not 100% sure.
I don't use the assignee functionality enough to know the implications.

@yardenshoham
Copy link
Collaborator Author

That's fine. So you're neutral about this. @techknowlogick do you approve?

@techknowlogick
Copy link
Collaborator

nixos kinda does this with their backport bot, so I'm for it :)

@yardenshoham yardenshoham merged commit f082d40 into main Mar 13, 2023
@yardenshoham yardenshoham deleted the feature/add-assignee-when-possible branch March 13, 2023 06:49
@yardenshoham
Copy link
Collaborator Author

Nice auto-merge experience right there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants