Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tool to rollForward to later dotnet versions #25

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

MattKotsenas
Copy link
Contributor

If only .NET 8 is installed (common in CI scenarios) the tool won't run because it requires .NET 6 or 7. Instead of adding another target framework for .NET 8, add the <RollForward>major</RollForward> property to the package so that the tool can run on newer runtimes if required.

See https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#rollforward for general information about rollForward.

See dotnet/sdk#10375 for additional details about rolling dotnet tools forward, and KirillOsenkov/MSBuildStructuredLog#721 for an example of other developer tools setting roll foward, and dotnet/sdk#30336 for more discussion on what the defaults should be.

If only .NET 8 is installed (common in CI scenarios) the tool won't run because it requires .NET 6 or 7. Instead of adding another target framework for .NET 8, add the `<RollForward>major</RollForward>` property to the package so that the tool can run on newer runtimes if required.

See https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#rollforward for general information about `rollForward`.

See dotnet/sdk#10375 for additional details about rolling dotnet tools forward, and KirillOsenkov/MSBuildStructuredLog#721 for an example of other developer tools setting roll foward, and dotnet/sdk#30336 for more discussion on what the defaults should be.
@MattKotsenas
Copy link
Contributor Author

Alternatively, I'm OK with adding net8.0 as a target framework instead, however that requires a new version for every .NET major release, and given that the tool is mostly a wrapper around an external process, the likelihood of breaking changes appears low.

@Gitii
Copy link
Owner

Gitii commented Feb 5, 2024

@MattKotsenas I am really sorry, I totally missed the GitHub notification! 🙁
I will look at your PR during the week or maybe on the weekend, there are some small improvements I want to do before doing a new release.

@Gitii Gitii merged commit 3d9c10c into Gitii:main Feb 10, 2024
@Gitii
Copy link
Owner

Gitii commented Feb 10, 2024

@MattKotsenas I've updated the package to prettier v3. Sadly I had to switch to deno because pkg does not support es modules and is deprecated, too. But deno has it's own limitations.
I hope that it covers your use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants