shallow protocol #770
Merged
shallow protocol #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
shallow-protocol
branch
5 times, most recently
from
6ea6700
to
a74b349
Compare
…ent readline behaviour. Previously the `async` version of the transport implementation would use the default `read_line` implementation which would search for newlines in packetlines. However, these aren't always emitted which could lead to multiple packetlines to be concatenated. Now the we always use our implementation which simply treats one packet line as line, no matter whether or not it ends with optional newline.
Also improve documentation for `FullName*` and `PartialName*` types.
That way can be sure the all capabilities are working like we think they do.
Also, we remove the existing blocking `read_line()` override as it's not representable in the async implementation anyway, to unify both implementations once again. The new name also makes sure that we are not accidentally calling a built-in implementation on the `BufRead` trait as it's clear our method has to be called under a different name.
…n for `Box<T: ReadlineBufRead>` as well. This fixes a bug where the HTTP implementation would incorrectly concatenate packetlines without newlines as sent by the server for shallow info lines.
Byron
force-pushed
the
shallow-protocol
branch
2 times, most recently
from
086c5a1
to
30aec54
Compare
TODO: more elaborate docs
TBD: more elaborate docs
…ies. TBD: more elaborate documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for
shallowclones on the protocol layer.Tasks
clone.rejectShallow,receive.shallowUpdateArgumentsimplementation can send shallow information correctlyclone.rejectShallowgixto allow it to be configured.