-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare API for upcoming UI changes #249
Conversation
I am going to request changes as I come across them when I am doing the frontend components. frontend/components/campaigns/campaignCharities/CampaignCharityCard.tsx in #252 would need PrimaryDonor name in the CampaignCharityDonationPublicData. |
I made the fixes in #252. Help check if its okay. |
020156a
to
a3c3934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Didn't really test everything as it will be easier to find issues during integration.
Changes
is_redeemed
column inCoupons
table withcampaign_charity_id
campaign_charity_id
to keep track which campaign charity this coupon was redeemed for.redeemed?
derived from whether thecampaign_charity_id
is null or notsecondary_donations
POST endpoint