Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redeem instructions #276

Merged
merged 19 commits into from
Oct 23, 2022
Merged

Add redeem instructions #276

merged 19 commits into from
Oct 23, 2022

Conversation

zognin
Copy link
Collaborator

@zognin zognin commented Oct 23, 2022

Closes #268

Can someone help test whether the ? button works in mobile because sometimes it works and sometimes it doesn't for me
Can someone help check the aspect ratio on big screens too? Cos I don't have a big screen.

Notes

  • Haven't added animations of instructions opening and closing
  • Slide content can prob change later, for now it's just the bare min
  • The ? button for mobile should be in the nav bar but for now it's like that because it's going to take a bit of work to do that so it's prob better to do that in another PR

Copy link
Contributor

@sivayogasubramanian sivayogasubramanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is what it looks like on a big screen

2022-10-23.20-40-12.mp4

I think the instructions can just be a normal modal in desktop?

frontend/components/redeem/Receipt.tsx Outdated Show resolved Hide resolved
frontend/components/redeem/Receipt.tsx Outdated Show resolved Hide resolved
frontend/components/redeem/Receipt.tsx Show resolved Hide resolved
frontend/pages/redeem/[urlToken]/index.tsx Show resolved Hide resolved
@zognin zognin enabled auto-merge October 23, 2022 16:06
@zognin zognin merged commit f8b80d6 into master Oct 23, 2022
@zognin zognin deleted the gengning/add-redeem-instructions branch October 23, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruction for redemption pages
2 participants