Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuckDB: Properly close all connections & database on shutdown #2151

Merged
merged 1 commit into from
Oct 31, 2024
Merged

DuckDB: Properly close all connections & database on shutdown #2151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,25 @@ const closeSQLite = async () => {
}
};

// Close properly all DuckDB connections & database
const closeDuckDB = async () => {
try {
await db.duckDb.close();
logger.info('DuckDB closed.');
return new Promise((resolve) => {
db.duckDbReadConnection.close((err1) => {
db.duckDbWriteConnection.close((err2) => {
db.duckDb.close((err3) => {
if (err1 || err2 || err3) {
logger.error(err1, err2, err3);
}
logger.info('DuckDB closed.');
resolve();
});
});
});
});
} catch (e) {
logger.info('DuckDB database is probably already closed');
logger.warn(e);
return null;
}
};

Expand Down
2 changes: 2 additions & 0 deletions server/models/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ const db = {
sequelize,
umzug,
duckDb,
duckDbWriteConnection,
duckDbReadConnection,
duckDbWriteConnectionAllAsync,
duckDbReadConnectionAllAsync,
duckDbCreateTableIfNotExist,
Expand Down
Loading