Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure handling #185

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Figure handling #185

merged 3 commits into from
Jul 17, 2023

Conversation

MartinMohrmann
Copy link
Member

This pull-request changes how figures are handled in the creation of GliderTools plots. Previously, the plt.tight_layout method was applied to all plots, making it impossible to use GliderTools for figures with advanced subplot layouts or manual matplotlib spacing changes in existing plots.
I changed the implicit manipulation of the Figure object for two reasons:

  1. The figure object is not an argument of the plot functions, thus a change of the figure parameters is unexpected and should be avoided.
  2. The creation of a figure object with other defaults than the matplotlib environments in the altered code felt unnecessary, the parameters outdated, and the code unflexible.

Changes are documented in the whatsnew.rst

@MartinMohrmann MartinMohrmann merged commit 2004155 into GliderToolsCommunity:master Jul 17, 2023
6 checks passed
@MartinMohrmann MartinMohrmann deleted the figure-handling branch July 17, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants