feat: make API signing secret a JvmSetting #7715 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #583
💛 - Coveralls |
poikilotherm
force-pushed
the
7715-jvmsetting
branch
from
fafa9b1
to
7b5ef16
Compare
poikilotherm
force-pushed
the
7715-jvmsetting
branch
from
7b5ef16
to
79f4c85
Compare
qqmyers
approved these changes
Nov 17, 2022
qqmyers
merged commit 70e350f
into
GlobalDataverseCommunityConsortium:7715-signed-urls-for-external-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add clean implementation of a JVM setting via
JvmSettings, enabling MPCONFIG, instead of using system properties only.