Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new symbol #199

Merged
merged 3 commits into from
May 2, 2023
Merged

added a new symbol #199

merged 3 commits into from
May 2, 2023

Conversation

hoseinit
Copy link

اضافه کردن پتروآگاه

@sfmqrb
Copy link
Collaborator

sfmqrb commented Apr 30, 2023

@hoseinit Thank you for the PR.

Please do the following to update symbols json file properly.

First go to scripts directory. Then run python update_symbols_json.py or in case you use poetry poetry run python update_symbols_json.py.

There are many tickers need to be updated and پتروآگاه is only one of them.

@hoseinit
Copy link
Author

hoseinit commented May 1, 2023

Thank you very much @sfmqrb for the comprehensive explanation.
I did what you told me, of course I needed to solve some issues in between because I am a newbie to Python.
I will contribute more to this repo in the future.

@sfmqrb
Copy link
Collaborator

sfmqrb commented May 1, 2023

LGTM @Glyphack

@Glyphack
Copy link
Owner

Glyphack commented May 2, 2023

Thanks @hoseinit for the contribution and @sfmqrb for the review 🚀

@Glyphack Glyphack merged commit 76bf6a4 into Glyphack:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants