Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic swim demo from work performed by pietru2004. #435

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request is a cleaned up version of Pietru2004's Water Demo.

For now it removes any attempts at advanced shading such as Volume Fog, and instead concentrates on the actual swimming movement. Rendering improvements can be added later.

@Malcolmnixon Malcolmnixon force-pushed the swim-demo branch 2 times, most recently from 6e7355b to a7a9ebf Compare April 8, 2023 20:00
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Apr 12, 2023
@Malcolmnixon Malcolmnixon marked this pull request as draft April 18, 2023 22:11
@Malcolmnixon
Copy link
Collaborator Author

I'm temporarily converting this back to a draft - a dedicated swimming movement provider is being developed in https://github.com/Malcolmnixon/GodotWildJam-56 which actually uses hand-movements to control swimming.

@pietru2004
Copy link
Contributor

On my defence I am in middle school and sometimes teachers are bit strange.

Anyway it is cool to hear that there will be dedicated swim, personally I want to say that I see both ways of valid - dedicated and using fly movement as swim.

@BastiaanOlij
Copy link
Member

@Malcolmnixon will have another look at this in the near future. We have a number of swimming implementations that we can revisit and see if we can properly embed into XR Tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants