Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double click on function_pointer #558

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

surreal6
Copy link
Contributor

The idea is to add double click actions (i.e.: to allow navigation in a FileDialog, that requieres double click to enter in a folder)

I added two different ways to solve:

  • one to detect double click in the trigger with an exposed debounce time

  • another by declaring a button to the complete double click action (safer for reduced mobility, as double clicking in the air is a bit dificult for some people) This second option is ignored if the value is left empty.

Let me know what you think :)

@Malcolmnixon
Copy link
Collaborator

The implementation looks reasonable. I wonder whether we should add something similar to poke.gd so people can trigger a double-tap with their finger. The duration would probably need to be a little longer due to no physical surface to use; although with the new haptic-system coming in it'll be easier to "feel" the touch and repeat a second one.

@BastiaanOlij
Copy link
Member

@Malcolmnixon to revisit this, looks good in general, we do feel the timer solution needs to change because there are situations this will fall over.

@BastiaanOlij BastiaanOlij added this to the 4.4.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants