Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hands: fix open and close pose script #627

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

esodan
Copy link
Contributor

@esodan esodan commented Apr 1, 2024

In order to add an animation, AnimationPlayer
should get its AnimationLibrary with empty name "".

This should fix #589

In order to add an animation, AnimationPlayer
should get its AnimationLibrary with empty name "".
@esodan esodan mentioned this pull request Apr 1, 2024
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Malcolmnixon Malcolmnixon merged commit f2c6f41 into GodotVR:master Apr 3, 2024
2 checks passed
@BastiaanOlij BastiaanOlij added this to the 4.3.2 milestone Jun 19, 2024
@BastiaanOlij BastiaanOlij added the bug Something isn't working label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no 'add_animation' function in AnimationPlayer any all
3 participants