Add support for XR_FB_android_surface_swapchain_create
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
fb-android-surface-swapchain-create
branch
2 times, most recently
from
74d2333
to
bfeacca
Compare
m4gr3d
approved these changes
Sep 22, 2024
|
Taking this out of draft now that the Godot PR has been merged. However, this actually won't pass tests on the XR Simulator until after 4.4-dev3 is released and I change the CI to point to that, so I guess this will still need to wait a bit before we can merge it. |
devloglogan
approved these changes
Sep 23, 2024
plugin/src/main/cpp/extensions/openxr_fb_android_surface_swapchain_create_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
dsnopek
force-pushed
the
fb-android-surface-swapchain-create
branch
from
bfeacca
to
2166ac9
Compare
dsnopek
force-pushed
the
fb-android-surface-swapchain-create
branch
from
2166ac9
to
027116e
Compare
|
FYI, this one is failing testing because of a bug in Godot 4.4-dev3 - see godotengine/godot#98102 It was fixed in PR godotengine/godot#98187 which is already merged and should be included in Godot 4.4-dev4. I'll update the CI to use 4.4-dev4 once it's released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
XR_FB_android_surface_swapchain_createwhich gives two new flags that can be used to customize the creation of Android surface swapchains.It depends on Godot PR godotengine/godot#97252 (so setting as a draft for now)
That means that this will require Godot 4.4, which is why it is also updating the
extension_api.jsonand godot-cpp. After this is merged, then themasterbranch will only work with Godot 4.4 (relating to our discussion from the last XR team meeting).