-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of Spotifiy API connection, including a test suite #18
Conversation
…icates with Spotify Authentication protocols)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, we can rework the tests in a future issue
…rent versions of jest mocking to accomplish this
Note: I made a small change to our CI workflow config file to include our Github Secrets as environment vars. Turns out it works! I wasn't sure if it was going to based on [https://github.com/actions/starter-workflows/issues/68](this issue thread). Anyway, you may want to check that too to make sure it looks good. My apologies for editing it directly in master, that won't happen again. |
For future reference:
I have since requested another review from @kyrod, who has much more experience with testing, as well as CI configuration (which I made a note about some changes above). Kyle, if you see any changes that should be made, I say we get those in before we push through this PR. That way we're pretty concrete with our testing structure before reaaaally diving in. Thanks 💯 |
…und these environment vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me bruther
Closes #10 |
This includes a JS based connection between our application and the Spotify API, allowing for easy development upon this structure.
Closes #9
After your review, we should meet to see the next steps for this project.