(Feature) Gender verification. Issue basic identity certificate #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsmith-gooddollar
changed the title
|
not tested yet, also needs unit tests, but could be reviewed |
…r into gender-verification
| @@ -292,8 +342,8 @@ const enrollmentProcessors = new WeakMap() | |||
|
|
|||
| export default (storage, log) => { | |||
| if (!enrollmentProcessors.has(storage)) { | |||
| log = log || logger.child({ from: 'EnrollmentProcessor' }) | |||
| const enrollmentProcessor = new EnrollmentProcessor(Config, storage, AdminWallet, log) | |||
| const processorLogger = log || logger.child({ from: 'EnrollmentProcessor' }) | |||
There was a problem hiding this comment.
actually processor shouldn't encapsulate logger. it should be passed as optional param to each method.
this should be fixed in a separate PR.
sirpy
requested changes
Mar 17, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sirpy
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
About #453 #454
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: