Correctly determine channel for APIs with dependencies. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When considering dependencies, we were incorrectly choosing the "most released" channel as the channel an API became available. This was causing some issues as, for example, action.openPopup is still restricted to dev but it has a dependency of the action key in the manifest which has existed in stable for a while. Fixing this should make the openPopup API correctly appear as restricted to dev, and also fix some other similar issues across the generated types.
|
This relates to GoogleChrome/developer.chrome.com#2602. It should be fixed once this change propagates through but I'm not going to link the two so we can keep the DCC PR open until we've confirmed. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 35.60% 35.61% +0.01%
==========================================
Files 21 21
Lines 3991 4015 +24
Branches 185 185
==========================================
+ Hits 1421 1430 +9
- Misses 2570 2585 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When considering dependencies, we were incorrectly choosing the "most released" channel as the channel an API became available. This was causing some issues as, for example, action.openPopup is still restricted to dev but it has a dependency of the action key in the manifest which has existed in stable for a while.
Fixing this should make the openPopup API correctly appear as restricted to dev, and also fix some other similar issues across the generated types.
I ran the tool and compared the generated types with the last published version of this package. There are only a dozen or so lines changed and the changes look reasonable, matching up to the versioning information I was able to find looking at when those APIs become available in the Chromium source.