Add defensive coding to BackfillShippingYear

GoogleChrome · Sep 13, 2024 · b783458 · b783458
1 parent 296c2b4
commit b783458
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/internals/maintenance_scripts.py b/internals/maintenance_scripts.py
@@ -759,10 +759,11 @@ def get_all_shipping_stages_with_milestones(self) -> list[Stage]:
         Stage.stage_type.IN(shipping_stage_types)).fetch()
     shipping_stages_with_milestones = [
         stage for stage in shipping_stages
-        if (stage.milestones.desktop_first or
-            stage.milestones.android_first or
-            stage.milestones.ios_first or
-            stage.milestones.webview_first)]
+        if (stage.milestones and
+            (stage.milestones.desktop_first or
+             stage.milestones.android_first or
+             stage.milestones.ios_first or
+             stage.milestones.webview_first))]
     return shipping_stages_with_milestones
 
   def calc_all_shipping_years(self) -> dict[int, int]: