OpenAPI: OT #4226
Merged
OpenAPI: OT #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markxiong0122
requested review from
DanielRyanSmith and
jrobbins
and removed request for
DanielRyanSmith
jrobbins
reviewed
Aug 21, 2024
| @@ -158,7 +161,8 @@ def do_post(self, **kwargs): | |||
| if gate.state not in (Vote.APPROVED, Vote.NA): | |||
| self.abort(400, 'Unapproved gate found for trial stage.') | |||
|
|
|||
| body = self.get_json_param_dict() | |||
| #TODO(markxiong0122): remove to_dict() when PR#4213 is merged | |||
There was a problem hiding this comment.
#4213 has has merged already.
DanielRyanSmith
approved these changes
Aug 22, 2024
I didn't find all OT pages so this indeed needs further testing. Thank you for helping with this! Should I merge this PR or wait until we test it locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented OAS on origin_trials_api