Add shipping_year field.

api/api_specs.py

@@ -31,6 +31,7 @@
   ('availability_expectation', 'str'),
   ('blink_components', 'split_str'),
   ('enterprise_impact', 'int'),
+  ('shipping_year', 'int'),
   ('breaking_change', 'bool'),
   ('bug_url', 'link'),
   ('category', 'int'),

api/converters.py

@@ -381,6 +381,7 @@ def feature_entry_to_json_verbose(
     'first_enterprise_notification_milestone': fe.first_enterprise_notification_milestone,
     'enterprise_impact': fe.enterprise_impact,
     'breaking_change': fe.breaking_change,
+    'shipping_year': fe.shipping_year,
     'flag_name': fe.flag_name,
     'finch_name': fe.finch_name,
     'non_finch_justification': fe.non_finch_justification,

api/converters_test.py

@@ -48,7 +48,7 @@ def setUp(self):
         updater_email='[email protected]', category=1,
         owner_emails=['[email protected]'], feature_type=0,
         editor_emails=['[email protected]', '[email protected]'],
-        impl_status_chrome=5, blink_components=['Blink'],
+        impl_status_chrome=5, blink_components=['Blink'], shipping_year=2024,
         spec_link='https://example.com/spec',
         sample_links=['https://example.com/samples'],
         screenshot_links=['https://example.com/screenshot'],
@@ -293,6 +293,7 @@ def test_feature_entry_to_json_verbose__normal(self):
       'unlisted': False,
       'api_spec': False,
       'enterprise_impact': ENTERPRISE_IMPACT_NONE,
+      'shipping_year': 2024,
       'breaking_change': False,
       'is_released': True,
       'category': 'Web Components',

client-src/elements/form-definition.ts

@@ -163,6 +163,7 @@ export const NEW_FEATURE_FORM_FIELDS = [
   'summary',
   'unlisted',
   'enterprise_impact',
+  'shipping_year',
   'owner',
   'editors',
   'cc_recipients',
@@ -193,6 +194,7 @@ export const FLAT_METADATA_FIELDS: MetadataFields = {
         'summary',
         'unlisted',
         'enterprise_impact',
+        'shipping_year',
         'owner',
         'editors',
         'cc_recipients',

client-src/elements/form-field-specs.ts

@@ -37,6 +37,7 @@ interface FieldAttrs {
   chromedash_split_pattern?: string;
   disabled?: boolean;
   min?: number;
+  max?: number;
 }
 
 interface MilestoneRange {
@@ -2023,6 +2024,16 @@ export const ALL_FIELDS: Record<string, Field> = {
     GitHub issues, or WICG page).`,
   },
 
+  shipping_year: {
+    type: 'input',
+    attrs: {type: 'number', min: 2000, max: 2050},
+    initial: new Date().getFullYear(),
+    required: true,
+    label: 'Estimated shipping year',
+    help_text: html` Estimate of the calendar year in which this will first ship
+    on any platform. E.g., 2024.`,
+  },
+
   enterprise_policies: {
     type: 'input',
     attrs: MULTI_STRING_FIELD_ATTRS,

internals/core_models.py

@@ -104,6 +104,7 @@ class FeatureEntry(ndb.Model):  # Copy from Feature
   first_enterprise_notification_milestone = ndb.IntegerProperty()
   enterprise_impact = ndb.IntegerProperty(default=ENTERPRISE_IMPACT_NONE)
   breaking_change = ndb.BooleanProperty(default=False)
+  shipping_year = ndb.IntegerProperty()
 
   # Implementation in Chrome
   impl_status_chrome = ndb.IntegerProperty(required=True, default=NO_ACTIVE_DEV)

internals/data_types.py

@@ -216,6 +216,7 @@ class VerboseFeatureDict(TypedDict):
   first_enterprise_notification_milestone: int | None
   breaking_change: bool
   enterprise_impact: int
+  shipping_year: int | None
 
   # Implementation in Chrome
   flag_name: str | None

pages/guide.py

@@ -60,6 +60,7 @@ def process_post_data(self, **kwargs):
     # TODO(jrobbins): Validate input, even though it is done on client.
 
     feature_type = int(self.form.get('feature_type', 0))
+    shipping_year = int(self.form.get('shipping_year', 0))
 
     has_enterprise_impact = int(self.form.get('enterprise_impact', '1')) > ENTERPRISE_IMPACT_NONE
     enterprise_notification_milestone = self.form.get('first_enterprise_notification_milestone')
@@ -90,6 +91,8 @@ def process_post_data(self, **kwargs):
         first_enterprise_notification_milestone=enterprise_notification_milestone,
         blink_components=blink_components,
         tag_review_status=processes.initial_tag_review_status(feature_type))
+    if shipping_year:
+      feature_entry.shipping_year = shipping_year
     key: ndb.Key = feature_entry.put()
     search_fulltext.index_feature(feature_entry)
 
@@ -258,6 +261,7 @@ def get_template_data(self, **defaults):
       ('feature_notes', 'str'),
       ('breaking_change', 'bool'),
       ('enterprise_impact', 'int'),
+      ('shipping_year', 'int'),
       ('ongoing_constraints', 'str')]
 
   # Old field name, new field name