-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI: feature_api #4263
Draft
markxiong0122
wants to merge
78
commits into
GoogleChrome:main
Choose a base branch
from
markxiong0122:openapi-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
OpenAPI: feature_api #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add shipping_year field. * formatting * updated screenshots * updated typedict * Updated screenshots again
…er-side) (GoogleChrome#4236) * No OT milestone edits during OT creation process * fix imports
* Implement fulltext search within a specific field. * Disable OT milestone edits during automated OT creation process (server-side) (GoogleChrome#4236) * No OT milestone edits during OT creation process * fix imports * Added tests cand updated comments --------- Co-authored-by: Daniel Smith <[email protected]>
…s (client-side) (GoogleChrome#4218) * disable changing OT milestones while OT is created * logic update * remove textarea disabled addition * change "helpText" to "disabledReason" * remove unnecessary variable
* Handle OpenAPI models correctly for GET requests * Update basehandlers_test.py
* progress * typo
* generated code * add models * map json fields * casting post objects to models * from dict * modify test to models * resolve conflicts * fix datetime * resolve conflicts * regenerate models * reorganize * changing helper names
* cast to models * changed to from_dict * delete param
* process * process models * seperate progress item * fix reserved word * progress * vote model * vote api done * get gates for a feature * xfn gates * remove white space * merge
* Obtain chromium source files concurrently * remove log * Update origin_trials_api.py
…me#4280) * Add default string conversion for dates * shipped_date kept as date format
* make certain props in feature links nullable * update openapi models * update TS type def for FeatureLink * remove information and http_error_code required * Use LinkPreview instead of LinkPreviewBase * information set to optional
* Run mypy on generated openapi code too. * fixed dep syntax and version number
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.0 to 4.21.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.0...v4.21.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.25.3 to 7.25.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.4/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* limit pagination length * Show +- 5 pages and the first/last page fix * Change the size to 4
* Pressing slash focuses on feature searchbox. * lint-fix
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.1 to 22.5.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [flask-cors](https://github.com/corydolphin/flask-cors) from 4.0.1 to 5.0.0. - [Release notes](https://github.com/corydolphin/flask-cors/releases) - [Changelog](https://github.com/corydolphin/flask-cors/blob/main/CHANGELOG.md) - [Commits](corydolphin/flask-cors@4.0.1...5.0.0) --- updated-dependencies: - dependency-name: flask-cors dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add rationale for the need for each gate. * lint
…ient-side) (GoogleChrome#4313) * OT creation allows WebDXFeature use counters * wording change * Update chromedash-ot-creation-page.ts
…rver-side) (GoogleChrome#4267) * Obtain chromium source files concurrently * remove log * Add validation logic for WebDXFeature use counters * Change implementation to use string prefix
* Revised testing gate rationale. * lint-fix
* Avoid a race condition when processing LGTMs. * Also undo double votes
* conditional prop access and TS definitions * move prefix logic into conditional block * lint-fix
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.4 to 5.6.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.4...v5.6.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.46.1 to 1.47.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.46.1...v1.47.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@web/test-runner](https://github.com/modernweb-dev/web/tree/HEAD/packages/test-runner) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/modernweb-dev/web/releases) - [Changelog](https://github.com/modernweb-dev/web/blob/master/packages/test-runner/CHANGELOG.md) - [Commits](https://github.com/modernweb-dev/web/commits/@web/[email protected]/packages/test-runner) --- updated-dependencies: - dependency-name: "@web/test-runner" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.9.1 to 9.10.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.9.1...v9.10.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.2 to 22.5.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rome#4214) * Implement retry logic for OT creation * remove sorting of contact list * Separate CreateTrial and SetupTrial requests * change endpoint name
* Implement retry logic for OT creation * remove sorting of contact list * Separate CreateTrial and SetupTrial requests * Add OT support emails secret for OT creation
* Make autocomplete offer enum values separately. * Clarified helper function.
* progress * Added tests and simplified logic. * Simplify for mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.