Hide and ignore use counter field for deprecation trials #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
approved these changes
Aug 23, 2024
DanielRyanSmith
force-pushed
the
2024-08-22_conditional-use-counter
branch
from
5222041
to
bcc11d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebFeature use counters are not needed (and shouldn't be supplied) for deprecation trials. The use counter field in the OT creation form is already optional when the deprecation trial checkbox is selected, but this change explicitly removes the use counter field from the form when the deprecation trial checkbox is checked.
Making this field inaccessible for deprecation trials is better because adding a use counter value might cause false positives when usage monitoring origin trials. Deprecation trial are not subject to rate limiting.
Screen.Recording.2024-08-22.at.4.13.38.PM.mov