Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record an Activity when assigning a reviewer. #4316

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jrobbins
Copy link
Collaborator

This resolves #4273.

There are two ways to assign a reviewer: via a UI menu, or by requesting a review which triggers auto-assignment. In each case we now create an Activity records that shows up as a comment on the gate.

@jrobbins jrobbins force-pushed the 20240829-auto-assignment-creates-Activity branch from 1973131 to 74d78c4 Compare August 30, 2024 15:33
@jrobbins jrobbins force-pushed the 20240829-auto-assignment-creates-Activity branch from 74d78c4 to a0cc09d Compare August 30, 2024 16:01
Copy link
Collaborator

@DanielRyanSmith DanielRyanSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jrobbins jrobbins merged commit ee836d2 into main Aug 30, 2024
7 checks passed
@jrobbins jrobbins deleted the 20240829-auto-assignment-creates-Activity branch August 30, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning a reviewer should create an Activity record on the gate
2 participants