Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main menu link for annual roadmap. #4332

Merged
merged 4 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion client-src/elements/chromedash-drawer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ export class ChromedashDrawer extends LitElement {
const myFeaturesMenu = this.renderMyFeaturesMenu();
const adminMenu = this.renderAdminMenu();

const year = new Date().getFullYear();
Copy link
Collaborator

@jcscottiii jcscottiii Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads-up for Jan 1: This will cause a lot of the playwright screenshot tests to break when the link changes from Shipping 2024 to Shipping 2025.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll follow up with a PR to elide that.

const shippingThisYear = this.renderNavItem(
'/features?q=shipping_year=' + year,
'Shipping ' + year
);

return html`
<sl-drawer
label="Menu"
Expand All @@ -272,7 +278,8 @@ export class ChromedashDrawer extends LitElement {
?open=${!IS_MOBILE && this.defaultOpen}
>
${accountMenu} ${this.renderNavItem('/roadmap', 'Roadmap')}
${this.renderNavItem('/features', 'All features')} ${myFeaturesMenu}
${this.renderNavItem('/features', 'All features')} ${shippingThisYear}
${myFeaturesMenu}
<hr />
<div class="section-header">Stats</div>
${this.renderNavItem('/metrics/css/popularity', 'CSS')}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.