Add Blink>HID #4371
Closed
Add Blink>HID #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
approved these changes
Sep 17, 2024
|
Actually, "Blink>HID" is already on line 76. So, I am not sure that this is needed. Testing it on the live site, I find that "Blink>HID" is already offered in the datalist UI element for choosing the blink component. |
jrobbins
requested changes
Sep 17, 2024
|
Did you mean to spell it as "Blink>WebHID"? |
|
I was wrong. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing Blink component for WebHID as it's needed for https://chromestatus.com/feature/5077348995825664