Cache full search results. #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
force-pushed
the
20240920-cache-full-search-result
branch
from
c4dee7c
to
677047c
Compare
KyleJu
reviewed
Sep 23, 2024
KyleJu
reviewed
Sep 23, 2024
KyleJu
reviewed
Sep 23, 2024
KyleJu
reviewed
Sep 23, 2024
KyleJu
reviewed
Sep 23, 2024
KyleJu
approved these changes
Sep 24, 2024
| 'show_enterprise=' + str(show_enterprise), | ||
| 'start=' + str(start), | ||
| 'num=' + str(num), | ||
| 'name_only=' + str(name_only), |
There was a problem hiding this comment.
Note: we only cache name_only queries for now. This part of the key is optional
There was a problem hiding this comment.
I think it is best to include it, just in case we decide to broaden what we cache.
DanielRyanSmith
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Cache full search results. * Addressed review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we chatted about, this adds redis caching of full search results.
In this PR:
process_query_using_cache()that wraps around aroundprocess_query(), and some helper functions to decide which queries are cacheable.rediscache.delete_keys_with_prefix()should take a prefix string rather than a pattern. This better fits the name of the function and the way that that it was being used.