Make the new feature search page the default #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
reviewed
Sep 24, 2024
| @@ -358,7 +358,8 @@ export class ChromedashApp extends LitElement { | |||
| this.pageComponent.showQuery = false; | |||
| this.pageComponent.rawQuery = parseRawQuery(ctx.querystring); | |||
| }); | |||
| page('/newfeatures', ctx => { | |||
| page('/newfeatures', () => page.redirect('/features')); | |||
| page('/features', ctx => { | |||
| if (!this.setupNewPage(ctx, 'chromedash-all-features-page', true)) return; | |||
| this.pageComponent.user = this.user; | |||
| this.pageComponent.rawQuery = parseRawQuery(ctx.querystring); | |||
There was a problem hiding this comment.
Lets rename the flag this.pageComponent.isNewfeaturesPage = true; to this.pageComponent.isFeaturesPage = true;
KyleJu
reviewed
Sep 24, 2024
| @@ -358,7 +358,8 @@ export class ChromedashApp extends LitElement { | |||
| this.pageComponent.showQuery = false; | |||
| this.pageComponent.rawQuery = parseRawQuery(ctx.querystring); | |||
| }); | |||
| page('/newfeatures', ctx => { | |||
| page('/newfeatures', () => page.redirect('/features')); | |||
| page('/features', ctx => { | |||
There was a problem hiding this comment.
Question about this - I know the old /features page was not a part of SPA. Is that the reason why it is not routed here before? e.g. there was no page('/features', ctx => {...
There was a problem hiding this comment.
Yes, exactly. And, now the old page is at /oldfeatures but that is not in the SPA routing because it is still an MPA page.
KyleJu
approved these changes
Sep 24, 2024
DanielRyanSmith
pushed a commit
that referenced
this pull request
Sep 26, 2024
* progress * Update goldens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that we have checked off everything that we had in mind for this feature, so it is time to finally make it the default this week.
In this PR: