When starting a new search, set start=0. #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #4217. When the user starts a new search, the start parameter should be set to 0. Before this PR, if the paged to a higher start and then did a search that generated a small number of results, it would say
no results.Also, we now show a distinct message if there are some search results, but the start= URL parameter was set to a higher value such that there are no results on that pagination page. E.g., before this PR,
?q=css&start=9999would sayno results. Now it saysno results on this pagination page.Also, add a little padding around the messages so that they are not too close to the search box.