Update shipping_year when milestones are edited. #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/features_api.py
Outdated
Comment on lines
263
to
265
| if updated_stages: | ||
| existing_shipping_stages = ( | ||
| stage_helpers.get_all_shipping_stages_with_milestones( |
There was a problem hiding this comment.
This seems like a large check for any time any stage is updated. Is it safe to check only when a shipping milestone is changed?
There was a problem hiding this comment.
Good point. Done.
DanielRyanSmith
approved these changes
Sep 27, 2024
jrobbins
deleted the
20240926-update-shipping_year-when-milestones-edited
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a feature owner fills in some shipping milestones, the feature's shipping_year should be calculated based on those milestones. This PR adds that calculation to the features_api.
In this PR:
fetch_chrome_release_info()into fetchchannels.py to avoid a circular import._patch_update_stages()now returns the list of stages that were updated so that we can check their milestones later.changed_fieldsare now passed into_patch_update_special_fields()so that we can check milestones and add a changed field item ifshipping_yearis set.