-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify feature accuracy notification email #4510
Conversation
I'm not certain here, but this could be a byproduct of [email protected] Google group sending these emails to our inbox. E.g. None of the actual emails have the prefix in the group
Yes - uncommenting the line here and then running the test will update the contents of the file that is being compared (be sure to re-comment the line back so it's not trying to rewrite the contents each time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much improved, thanks! I didn't look at the code too closely as I assume Jason will, but I have one more nit: can we refer to the "Chromestatus team" instead of the "Webstatus team" everywhere, including the email subject if possible?
Nowadays with webstatus.dev being a separate thing, the confusion becomes a bit more concerning.
I'd prefer not to use gray text. The fact that it comes last should be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after one nit.
I have a few ideas in #4355 (comment). Overall, the idea is to simplify the sentences and reduce the overhead of reading it. Instead highlight the actions on top.
Remove use of extra []s and change wording in email subjects:
[webstatus] [Action requested] Update Saved queries in sharedStorage.selectURL
to[webstatus] Action requested - Verify Saved queries in sharedStorage.selectURL
[webstatus] ESCALATED: [Action requested] Update Saved queries in sharedStorage.selectURL
to[webstatus] Escalation request - Verify Saved queries in sharedStorage.selectURL
Rearrange the email body:
Verify feature accuracy
button to the topRegular accuracy notification (Note that the email subject in prod will start with [webstatus]):
Escalation email:
Before this change:
Other ideas
On top of it, wdyt if I grey the section under
id=why-triggered
? Normally the explanation for "why I receive this email" is always greyed in the email