Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify feature accuracy notification email #4510

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Simplify feature accuracy notification email #4510

merged 3 commits into from
Nov 5, 2024

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Oct 31, 2024

I have a few ideas in #4355 (comment). Overall, the idea is to simplify the sentences and reduce the overhead of reading it. Instead highlight the actions on top.

Remove use of extra []s and change wording in email subjects:

  • From [webstatus] [Action requested] Update Saved queries in sharedStorage.selectURL to [webstatus] Action requested - Verify Saved queries in sharedStorage.selectURL
  • When escalation, from [webstatus] ESCALATED: [Action requested] Update Saved queries in sharedStorage.selectURL to [webstatus] Escalation request - Verify Saved queries in sharedStorage.selectURL

Rearrange the email body:

  • Move Verify feature accuracy button to the top
  • Merge four sections into three
  • Highlight the feature is launched soon in the first sentence

Regular accuracy notification (Note that the email subject in prod will start with [webstatus]):
Screenshot 2024-11-01 7 44 06 PM

Escalation email:
Screenshot 2024-11-01 7 46 01 PM

Before this change:
Screenshot 2024-11-01 7 48 32 PM

Other ideas

On top of it, wdyt if I grey the section under id=why-triggered? Normally the explanation for "why I receive this email" is always greyed in the email

Screenshot 2024-10-31 4 59 48 PM

@KyleJu KyleJu requested a review from jrobbins November 1, 2024 00:00
@DanielRyanSmith
Copy link
Collaborator

  1. Where does the [webstatus] prefix come from in the email subject?

I'm not certain here, but this could be a byproduct of [email protected] Google group sending these emails to our inbox. E.g. None of the actual emails have the prefix in the group

  1. Is there a way to update test_build_email_tasks_escalated_feature_accuracy.html test automatically?

Yes - uncommenting the line here and then running the test will update the contents of the file that is being compared (be sure to re-comment the line back so it's not trying to rewrite the contents each time)

@KyleJu KyleJu changed the title [Draft] Change outdated feature notification emails Simplify feature accuracy notification email Nov 2, 2024
@KyleJu KyleJu requested a review from past November 2, 2024 02:49
@KyleJu KyleJu marked this pull request as ready for review November 2, 2024 02:49
Copy link
Collaborator

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much improved, thanks! I didn't look at the code too closely as I assume Jason will, but I have one more nit: can we refer to the "Chromestatus team" instead of the "Webstatus team" everywhere, including the email subject if possible?

Nowadays with webstatus.dev being a separate thing, the confusion becomes a bit more concerning.

templates/accuracy_notice_email.html Show resolved Hide resolved
@jrobbins
Copy link
Collaborator

jrobbins commented Nov 5, 2024

On top of it, wdyt if I grey the section under id=why-triggered?

I'd prefer not to use gray text. The fact that it comes last should be enough.

Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after one nit.

internals/reminders.py Outdated Show resolved Hide resolved
templates/accuracy_notice_email.html Show resolved Hide resolved
@KyleJu KyleJu merged commit 7debf8a into main Nov 5, 2024
7 checks passed
@KyleJu KyleJu deleted the escala-email branch November 5, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants