Skip to content

Commit

Permalink
update feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhulce committed Jan 23, 2017
1 parent 0116b4c commit 3272942
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class UsesResponsiveImages extends Audit {
category: 'Images',
name: 'uses-responsive-images',
description: 'Site uses appropriate image sizes',
helpText: 'Image sizes served should be based on the display size to save network bytes. ' +
helpText: 'Image sizes served should be based on the device display size to save network bytes. ' +
'Learn more about [responsive images](https://developers.google.com/web/fundamentals/design-and-ui/media/images) ' +
'and [client hints](https://developers.google.com/web/updates/2015/09/automating-resource-selection-with-client-hints).',
requiredArtifacts: ['ImageUsage', 'ContentWidth']
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/gatherers/image-usage.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function collectImageElementInfo() {
const relativeUrls = entries.map(entry => entry.trim().split(' ')[0]);
return relativeUrls.map(url => {
try {
return new URL(url, window.location.href).href;
return new URL(url, document.baseURI || window.location.href).href;
} catch (e) {
return url;
}
Expand Down

0 comments on commit 3272942

Please sign in to comment.