don't include all of @types/node for Buffer.from().toString()

GoogleChrome · Aug 20, 2021 · 5533b93 · 5533b93
1 parent 2fe04d9
commit 5533b93
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/report/renderer/logger.js b/report/renderer/logger.js
@@ -40,7 +40,7 @@ export class Logger {
     this.el.textContent = msg;
     this.el.classList.add('show');
     if (autoHide) {
-      this._id = setTimeout(_ => {
+      this._id = setTimeout(() => {
         this.el.classList.remove('show');
       }, 7000);
     }
@@ -61,7 +61,7 @@ export class Logger {
 
     // Rethrow to make sure it's auditable as an error, but in a setTimeout so page
     // recovers gracefully and user can try loading a report again.
-    setTimeout(_ => {
+    setTimeout(() => {
       throw new Error(msg);
     }, 0);
   }

diff --git a/report/renderer/report-ui-features.js b/report/renderer/report-ui-features.js
@@ -705,7 +705,7 @@ export class ReportUIFeatures {
 
     // cleanup.
     this._document.body.removeChild(a);
-    setTimeout(_ => URL.revokeObjectURL(a.href), 500);
+    setTimeout(() => URL.revokeObjectURL(a.href), 500);
   }
 
   /**

diff --git a/report/tsconfig.json b/report/tsconfig.json
@@ -7,8 +7,8 @@
 
     // Limit to base JS and DOM defs.
     "lib": ["es2020", "dom", "dom.iterable"],
-    // Include `@types/node` for use of `Buffer` in text-encoding.js.
-    "types": ["node"],
+    // Don't include any node_module types.
+    "types": [],
     "target": "es2020",
     "module": "es2020",
     "moduleResolution": "node",