Rename type to metricTag

GoogleChrome · Apr 2, 2020 · 597c071 · 597c071
1 parent e05c36f
commit 597c071
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 17 deletions.
diff --git a/lighthouse-core/audits/metrics/largest-contentful-paint.js b/lighthouse-core/audits/metrics/largest-contentful-paint.js
@@ -49,7 +49,7 @@ class LargestContentfulPaint extends Audit {
    * @return {LH.Audit.Details.Table['items']}
    */
   static getNodeData(traceNodes) {
-    const lcpNode = traceNodes.find(node => node.type === 'lcp');
+    const lcpNode = traceNodes.find(node => node.metricTag === 'lcp');
     if (!lcpNode) {
       return [];
     }

diff --git a/lighthouse-core/gather/driver.js b/lighthouse-core/gather/driver.js
@@ -1237,19 +1237,6 @@ class Driver {
     return flattenedDocument.nodes ? flattenedDocument.nodes : [];
   }
 
-  /**
-   * @param {number} nodeId
-   * @param {string} attributeName
-   * @param {string} attributeValue
-   */
-  async setNodeAttribute(nodeId, attributeName, attributeValue) {
-    await this.sendCommand('DOM.setAttributeValue', {
-      nodeId: nodeId,
-      name: attributeName,
-      value: attributeValue,
-    });
-  }
-
   /**
    * @param {{x: number, y: number}} position
    * @return {Promise<void>}

diff --git a/lighthouse-core/gather/gatherers/trace-nodes.js b/lighthouse-core/gather/gatherers/trace-nodes.js
@@ -21,7 +21,7 @@ function collectTraceNodes() {
 
   for (const element of markedElements) {
     traceNodes.push({
-      type: element.getAttribute('lhtemp') || '',
+      metricTag: element.getAttribute('lhtemp') || '',
       // @ts-ignore - put into scope via stringification
       nodePath: getNodePath(element), // eslint-disable-line no-undef
       // @ts-ignore - put into scope via stringification
@@ -56,7 +56,11 @@ class TraceNodes extends Gatherer {
       await driver.sendCommand('DOM.getDocument', {depth: -1, pierce: true});
       const translatedIds = await driver.sendCommand('DOM.pushNodesByBackendIdsToFrontend',
         {backendNodeIds: [backendNodeId]});
-      driver.setNodeAttribute(translatedIds.nodeIds[0], 'lhtemp', 'lcp');
+      await driver.sendCommand('DOM.setAttributeValue', {
+        nodeId: translatedIds.nodeIds[0],
+        name: 'lhtemp',
+        value: 'lcp',
+      });
     }
 
     const expression = `(() => {

diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts
@@ -455,7 +455,7 @@ declare global {
       }
 
       export interface TraceNode {
-        type: string;
+        metricTag: string;
         selector: string;
         nodeLabel?: string;
         nodePath: string;