report: make red/orange/green score color thresholds tougher (#5831)

GoogleChrome · Aug 14, 2018 · 85e6ba9 · 85e6ba9
1 parent bb44a7d
commit 85e6ba9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lighthouse-core/report/html/renderer/util.js b/lighthouse-core/report/html/renderer/util.js
@@ -20,11 +20,11 @@
 
 const ELLIPSIS = '\u2026';
 const NBSP = '\xa0';
-const PASS_THRESHOLD = 0.75;
+const PASS_THRESHOLD = 0.9;
 
 const RATINGS = {
   PASS: {label: 'pass', minScore: PASS_THRESHOLD},
-  AVERAGE: {label: 'average', minScore: 0.45},
+  AVERAGE: {label: 'average', minScore: 0.5},
   FAIL: {label: 'fail'},
   ERROR: {label: 'error'},
 };

diff --git a/lighthouse-core/test/report/html/renderer/util-test.js b/lighthouse-core/test/report/html/renderer/util-test.js
@@ -83,10 +83,11 @@ describe('util helpers', () => {
   it('calculates a score ratings', () => {
     assert.equal(Util.calculateRating(0.0), 'fail');
     assert.equal(Util.calculateRating(0.10), 'fail');
-    assert.equal(Util.calculateRating(0.45), 'average');
-    assert.equal(Util.calculateRating(0.55), 'average');
-    assert.equal(Util.calculateRating(0.75), 'pass');
-    assert.equal(Util.calculateRating(0.80), 'pass');
+    assert.equal(Util.calculateRating(0.45), 'fail');
+    assert.equal(Util.calculateRating(0.5), 'average');
+    assert.equal(Util.calculateRating(0.75), 'average');
+    assert.equal(Util.calculateRating(0.80), 'average');
+    assert.equal(Util.calculateRating(0.90), 'pass');
     assert.equal(Util.calculateRating(1.00), 'pass');
   });