Skip to content

Commit

Permalink
clients(devtools): update version in tests on lh roll (#8819)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored and brendankenny committed May 20, 2019
1 parent cdb3696 commit 9ce6fad
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions lighthouse-core/scripts/roll-to-devtools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ else
frontend_dir="$chromium_dir/third_party/blink/renderer/devtools/front_end"
fi

tests_dir="$frontend_dir/../../../web_tests/http/tests/devtools/audits2"

if [[ ! -d "$frontend_dir" || ! -a "$frontend_dir/Runtime.js" ]]; then
echo -e "\033[31m✖ Error!\033[39m"
echo "This script requires a devtools frontend folder. We didn't find one here:"
Expand All @@ -42,3 +44,9 @@ echo -e "\033[96m ✓\033[39m (Potentially stale) lighthouse-dt-bundle copied."

# copy report generator + cached resources into $fe_lh_dir
cp -r dist/dt-report-resources/ $fe_lh_dir

# update expected version string in tests
VERSION=$(node -e "console.log(require('./package.json').version)")
sed -i '' -e "s/Version:.*/Version: $VERSION/g" "$tests_dir"/*-expected.txt

echo "Done. To rebase the test expectations, run: ~/chromium/src/third_party/blink/tools/run_web_tests.py --no-retry 'http/tests/devtools/audits2/*' --reset-results"

0 comments on commit 9ce6fad

Please sign in to comment.