Skip to content

Commit

Permalink
core(trace-engine-result): disable invalidations handler (#16142)
Browse files Browse the repository at this point in the history
  • Loading branch information
adamraine authored Aug 6, 2024
1 parent fa8489d commit 9d8cd25
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion core/computed/trace-engine-result.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@ class TraceEngineResult {
* @return {Promise<LH.Artifacts.TraceEngineResult>}
*/
static async runTraceEngine(traceEvents) {
const processor = TraceEngine.TraceProcessor.createWithAllHandlers();
const traceHandlers = {...TraceEngine.TraceHandlers};

// @ts-expect-error Temporarily disable this handler
// It's not currently used anywhere in trace engine insights or Lighthouse.
// TODO: Re-enable this when its memory usage is improved in the trace engine
// https://github.com/GoogleChrome/lighthouse/issues/16111
delete traceHandlers.Invalidations;

const processor = new TraceEngine.TraceProcessor(traceHandlers);

// eslint-disable-next-line max-len
await processor.parse(/** @type {import('@paulirish/trace_engine').Types.TraceEvents.TraceEventData[]} */ (
traceEvents
Expand Down

0 comments on commit 9d8cd25

Please sign in to comment.