misc: rename lantern master values to baseline values (#10950)

lighthouse-core/scripts/lantern/assert-master-lantern-values-unchanged.js → lighthouse-core/scripts/lantern/assert-baseline-lantern-values-unchanged.js

@@ -16,15 +16,15 @@ const chalk = require('chalk').default;
 
 const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_WITH_COMPUTED_PATH;
 const HEAD_PATH = path.resolve(process.cwd(), INPUT_PATH);
-const MASTER_PATH = constants.MASTER_COMPUTED_PATH;
-const MASTER_ACCURACY_PATH = constants.MASTER_ACCURACY_PATH;
+const BASELINE_PATH = constants.BASELINE_COMPUTED_PATH;
+const BASELINE_ACCURACY_PATH = constants.BASELINE_ACCURACY_PATH;
 
-if (!fs.existsSync(HEAD_PATH) || !fs.existsSync(MASTER_PATH)) {
+if (!fs.existsSync(HEAD_PATH) || !fs.existsSync(BASELINE_PATH)) {
   throw new Error('Usage $0 <computed file>');
 }
 
 const computedResults = require(HEAD_PATH);
-const expectedResults = require(MASTER_PATH);
+const expectedResults = require(BASELINE_PATH);
 
 /** @type {Array<{url: string, maxDiff: number, diffsForSite: Array<DiffForSite>}>} */
 const diffs = [];
@@ -58,7 +58,7 @@ if (diffs.length) {
       const metric = `    - ${entry.metricName.padEnd(25)}`;
       const diff = entry.diff > 0 ? chalk.yellow(`+${entry.diff}`) : chalk.cyan(`${entry.diff}`);
       const actual = `${entry.actual} ${chalk.gray('(HEAD)')}`;
-      const expected = `${entry.expected} ${chalk.gray('(master)')}`;
+      const expected = `${entry.expected} ${chalk.gray('(baseline)')}`;
       console.log(`${metric}${diff}\t${actual}\tvs.\t${expected}`);
     });
   });
@@ -67,7 +67,7 @@ if (diffs.length) {
 } else {
   assert.deepStrictEqual(
     constants.evaluateAllMetrics(computedResults, expectedResults),
-    require(MASTER_ACCURACY_PATH)
+    require(BASELINE_ACCURACY_PATH)
   );
   console.log('✅  PASS    No changes between expected and computed!');
 }

lighthouse-core/scripts/lantern/constants.js

@@ -81,9 +81,9 @@ module.exports = {
   // prettier-ignore
   SITE_INDEX_WITH_GOLDEN_WITH_COMPUTED_PATH: path.join(__dirname, '../../../.tmp/site-index-plus-golden-expectations-plus-computed.json'),
   // prettier-ignore
-  MASTER_COMPUTED_PATH: path.join(__dirname, '../../test/fixtures/lantern-master-computed-values.json'),
+  BASELINE_COMPUTED_PATH: path.join(__dirname, '../../test/fixtures/lantern-baseline-computed-values.json'),
   // prettier-ignore
-  MASTER_ACCURACY_PATH: path.join(__dirname, '../../test/fixtures/lantern-master-accuracy.json'),
+  BASELINE_ACCURACY_PATH: path.join(__dirname, '../../test/fixtures/lantern-baseline-accuracy.json'),
   /**
    * @param {{sites: Array<LanternSiteDefinition>}} siteIndexWithComputed
    * @param {{sites: Array<LanternMetrics & {url: string}>}} baselineLanternData

lighthouse-core/scripts/lantern/print-correlations.js

@@ -24,8 +24,7 @@ const OK_DIFF_AS_PERCENT_THRESHOLD = 0.5;
 
 const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_WITH_COMPUTED_PATH;
 const COMPUTATIONS_PATH = path.resolve(process.cwd(), INPUT_PATH);
-const BASELINE_PATH = constants.MASTER_COMPUTED_PATH;
-
+const BASELINE_PATH = constants.BASELINE_COMPUTED_PATH;
 
 if (!fs.existsSync(COMPUTATIONS_PATH)) throw new Error('Usage $0 <computed summary file>');
 

lighthouse-core/scripts/lantern/update-master-lantern-values.js → lighthouse-core/scripts/lantern/update-baseline-lantern-values.js

@@ -18,8 +18,8 @@ const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_PATH;
 const SITE_INDEX_PATH = path.resolve(process.cwd(), INPUT_PATH);
 const HEAD_COMPUTED_PATH = constants.SITE_INDEX_WITH_GOLDEN_WITH_COMPUTED_PATH;
 const RUN_ALL_SCRIPT_PATH = path.join(__dirname, 'run-on-all-assets.js');
-const OUTPUT_PATH = constants.MASTER_COMPUTED_PATH;
-const OUTPUT_ACCURACY_PATH = constants.MASTER_ACCURACY_PATH;
+const OUTPUT_PATH = constants.BASELINE_COMPUTED_PATH;
+const OUTPUT_ACCURACY_PATH = constants.BASELINE_ACCURACY_PATH;
 
 if (!fs.existsSync(HEAD_COMPUTED_PATH) || process.env.FORCE) {
   if (!fs.existsSync(SITE_INDEX_PATH)) throw new Error('Usage $0 <expectations file>');
@@ -47,5 +47,3 @@ fs.writeFileSync(OUTPUT_ACCURACY_PATH, JSON.stringify(
   null,
   2
 ));
-
-

lighthouse-core/scripts/test-lantern.sh

@@ -35,5 +35,5 @@ printf "\n\nRunning lantern on all sites...\n"
 printf "\n\n"
 "$LH_ROOT/lighthouse-core/scripts/lantern/print-correlations.js"
 
-printf "\n\nComparing to master computed values...\n"
-"$LH_ROOT/lighthouse-core/scripts/lantern/assert-master-lantern-values-unchanged.js"
+printf "\n\nComparing to baseline computed values...\n"
+"$LH_ROOT/lighthouse-core/scripts/lantern/assert-baseline-lantern-values-unchanged.js"

package.json

@@ -66,7 +66,7 @@
     "type-check": "tsc -p . && tsc -p lighthouse-viewer/ && tsc -p lighthouse-treemap/",
     "i18n:checks": "./lighthouse-core/scripts/i18n/assert-strings-collected.sh",
     "i18n:collect-strings": "node lighthouse-core/scripts/i18n/collect-strings.js",
-    "update:lantern-master": "node lighthouse-core/scripts/lantern/update-master-lantern-values.js",
+    "update:lantern-baseline": "node lighthouse-core/scripts/lantern/update-baseline-lantern-values.js",
     "update:sample-artifacts": "node lighthouse-core/scripts/update-report-fixtures.js",
     "update:sample-json": "yarn i18n:collect-strings && node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --config-path=./lighthouse-core/test/results/sample-config.js --output=json --output-path=./lighthouse-core/test/results/sample_v2.json && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing",
     "update:test-devtools": "bash lighthouse-core/test/chromium-web-tests/test-locally.sh --reset-results",