Skip to content

Commit

Permalink
tests: upgrade jest to fix current node 11 build (#7413)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattzeunert authored and paulirish committed Mar 7, 2019
1 parent 5674d61 commit b1d2b83
Show file tree
Hide file tree
Showing 4 changed files with 1,204 additions and 694 deletions.
2 changes: 1 addition & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = {
'!**/test/',
'!**/scripts/',
],
setupTestFrameworkScriptFile: './lighthouse-core/test/test-utils.js',
setupFilesAfterEnv: ['./lighthouse-core/test/test-utils.js'],
testEnvironment: 'node',
testMatch: [
'**/lighthouse-core/**/*-test.js',
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/test/computed/manifest-values-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('ManifestValues computed artifact', () => {
assert.equal(results.allChecks.every(i => i.passing), true, 'not all checks passed');
});

describe('color checks', async () => {
describe('color checks', () => {
it('fails when a minimal manifest contains no background_color', async () => {
const WebAppManifest = noUrlManifestParser(JSON.stringify({
start_url: '/',
Expand Down Expand Up @@ -120,7 +120,7 @@ describe('ManifestValues computed artifact', () => {
});
});

describe('icons checks', async () => {
describe('icons checks', () => {
describe('icons exist check', () => {
it('fails when a manifest contains no icons array', async () => {
const manifestSrc = JSON.stringify({
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"@types/google.analytics": "0.0.39",
"@types/inquirer": "^0.0.35",
"@types/intl-messageformat": "^1.3.0",
"@types/jest": "^23.3.10",
"@types/jest": "^24.0.9",
"@types/jpeg-js": "^0.3.0",
"@types/lodash.isequal": "^4.5.2",
"@types/make-dir": "^1.0.3",
Expand Down Expand Up @@ -115,7 +115,7 @@
"glob": "^7.1.3",
"idb-keyval": "2.2.0",
"intl": "^1.2.5",
"jest": "^23.6.0",
"jest": "^24.3.0",
"jsdom": "^12.2.0",
"make-dir": "^1.3.0",
"mocha": "^3.2.0",
Expand Down Expand Up @@ -143,6 +143,7 @@
"inquirer": "^3.3.0",
"intl-messageformat": "^2.2.0",
"intl-messageformat-parser": "^1.4.0",
"jest-mock": "^24.3.0",
"jpeg-js": "0.1.2",
"js-library-detector": "^5.1.0",
"lighthouse-logger": "^1.2.0",
Expand Down
Loading

0 comments on commit b1d2b83

Please sign in to comment.